From 4ac1e8824d4a8de8eb557641a238a2611a40eb64 Mon Sep 17 00:00:00 2001
From: Dennis Postma <dennis@directonline.io>
Date: Mon, 17 Feb 2025 01:20:27 +0100
Subject: [PATCH] Socket event enum enhancement

---
 src/application/enums.ts      | 6 ++++--
 src/events/disconnect.ts      | 2 +-
 src/managers/socketManager.ts | 3 ++-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/application/enums.ts b/src/application/enums.ts
index 563b4f9..9689bf9 100644
--- a/src/application/enums.ts
+++ b/src/application/enums.ts
@@ -1,4 +1,6 @@
 export enum SocketEvent {
+  CONNECT_ERROR = 'connect_error',
+  RECONNECT_FAILED = 'reconnect_failed',
   CLOSE = '52',
   DATA = '51',
   CHARACTER_CONNECT = '50',
@@ -35,7 +37,7 @@ export enum SocketEvent {
   GM_MAP_REQUEST = '19',
   GM_MAP_UPDATE = '18',
   MAP_CHARACTER_MOVEERROR = '17',
-  DISCONNECT = '16',
+  DISCONNECT = 'disconnect',
   USER_DISCONNECT = '15',
   LOGIN = '14',
   LOGGED_IN = '13',
@@ -43,7 +45,7 @@ export enum SocketEvent {
   DATE = '11',
   FAILED = '10',
   COMPLETED = '9',
-  CONNECTION = '8',
+  CONNECTION = 'connection',
   WEATHER = '7',
   CHARACTER_DISCONNECT = '6',
   MAP_CHARACTER_ATTACK = '5',
diff --git a/src/events/disconnect.ts b/src/events/disconnect.ts
index f570ce3..3ba5205 100644
--- a/src/events/disconnect.ts
+++ b/src/events/disconnect.ts
@@ -4,7 +4,7 @@ import MapManager from '@/managers/mapManager'
 
 export default class DisconnectEvent extends BaseEvent {
   public listen(): void {
-    this.socket.on('disconnect', this.handleEvent.bind(this))
+    this.socket.on(SocketEvent.DISCONNECT, this.handleEvent.bind(this))
   }
 
   private async handleEvent(): Promise<void> {
diff --git a/src/managers/socketManager.ts b/src/managers/socketManager.ts
index 3558dd9..0f202a7 100644
--- a/src/managers/socketManager.ts
+++ b/src/managers/socketManager.ts
@@ -6,6 +6,7 @@ import Storage from '@/application/storage'
 import type { TSocket, UUID } from '@/application/types'
 import { Authentication } from '@/middleware/authentication'
 import { Server as SocketServer } from 'socket.io'
+import {SocketEvent} from "@/application/enums";
 
 class SocketManager {
   private io: SocketServer | null = null
@@ -21,7 +22,7 @@ class SocketManager {
     this.io.use(Authentication)
 
     // Set up connection handler
-    this.io.on('connection', this.handleConnection.bind(this))
+    this.io.on(SocketEvent.CONNECTION, this.handleConnection.bind(this))
   }
 
   /**