From a0584c2bb9bb8c370bea3d8c69662d444d6a9ee3 Mon Sep 17 00:00:00 2001
From: Dennis Postma <dennis@directonline.io>
Date: Fri, 24 Jan 2025 23:52:56 +0100
Subject: [PATCH] Inline checking for less written code; removed unused import

---
 src/events/chat/gameMaster/toggleFogCommand.ts  | 10 ++--------
 src/events/chat/gameMaster/toggleRainCommand.ts | 10 ++--------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/src/events/chat/gameMaster/toggleFogCommand.ts b/src/events/chat/gameMaster/toggleFogCommand.ts
index 1d69c39..27c2ac3 100644
--- a/src/events/chat/gameMaster/toggleFogCommand.ts
+++ b/src/events/chat/gameMaster/toggleFogCommand.ts
@@ -1,6 +1,5 @@
 import { BaseEvent } from '#application/base/baseEvent'
 import WeatherManager from '#managers/weatherManager'
-import CharacterRepository from '#repositories/characterRepository'
 import ChatService from '#services/chatService'
 
 type TypePayload = {
@@ -22,13 +21,8 @@ export default class ToggleFogCommand extends BaseEvent {
 
       const args = ChatService.getArgs('fog', data.message)
 
-      if (args![0]) {
-        await WeatherManager.setFogValue(Number(args![0]))
-      }
-      else {
-        await WeatherManager.setFogValue(null)
-      }
-
+      await WeatherManager.setFogValue(args![0] ? Number(args![0]) : null);
+      callback(true)
     } catch (error: any) {
       this.logger.error('command error', error.message)
       callback(false)
diff --git a/src/events/chat/gameMaster/toggleRainCommand.ts b/src/events/chat/gameMaster/toggleRainCommand.ts
index 0c58314..f8bc3a7 100644
--- a/src/events/chat/gameMaster/toggleRainCommand.ts
+++ b/src/events/chat/gameMaster/toggleRainCommand.ts
@@ -1,6 +1,5 @@
 import { BaseEvent } from '#application/base/baseEvent'
 import WeatherManager from '#managers/weatherManager'
-import CharacterRepository from '#repositories/characterRepository'
 import ChatService from '#services/chatService'
 
 type TypePayload = {
@@ -22,13 +21,8 @@ export default class ToggleRainCommand extends BaseEvent {
 
       let args = ChatService.getArgs('rain', data.message)
 
-      if (args![0]) {
-        await WeatherManager.setRainValue(Number(args![0]))
-      }
-      else {
-        await WeatherManager.setRainValue(null)
-      }
-
+      await WeatherManager.setRainValue(args![0] ? Number(args![0]) : null);
+      callback(true)
     } catch (error: any) {
       this.logger.error('command error', error.message)
       callback(false)