noxious_server/src/events/map/characterMove.ts

import { BaseEvent } from '@/application/base/baseEvent'
import { SocketEvent } from '@/application/enums'
import type { MapEventTileWithTeleport } from '@/application/types'
import MapManager from '@/managers/mapManager'
import MapCharacter from '@/models/mapCharacter'
import MapEventTileRepository from '@/repositories/mapEventTileRepository'
import CharacterService from '@/services/characterMoveService'
import TeleportService from '@/services/characterTeleportService'

export default class CharacterMove extends BaseEvent {
  private readonly characterService = CharacterService
  private readonly MOVEMENT_THROTTLE = 230 // Minimum time between movement requests

  public listen(): void {
    this.socket.on(SocketEvent.MAP_CHARACTER_MOVE, this.handleEvent.bind(this))
  }

  private async handleEvent({ positionX, positionY }: { positionX: number; positionY: number }): Promise<void> {
    const mapCharacter = MapManager.getCharacterById(this.socket.characterId)
    if (!mapCharacter?.getCharacter()) {
      this.logger.error('map:character:move error: Character not found or not initialized')
      return
    }

    if (this.isThrottled(`movement_${this.socket.characterId}`, this.MOVEMENT_THROTTLE)) {
      // Only cancel current movement if the new target is different
      if (mapCharacter.isMoving && (Math.floor(positionX) !== Math.floor(mapCharacter.character.positionX) || Math.floor(positionY) !== Math.floor(mapCharacter.character.positionY))) {
        mapCharacter.isMoving = false
        mapCharacter.currentPath = null
        // this.finalizeMovement(mapCharacter)
      }
      return
    }

    // If already moving, cancel current movement
    if (mapCharacter.isMoving && mapCharacter.currentPath && mapCharacter.currentPath.length > 2) {
      mapCharacter.isMoving = false
      mapCharacter.currentPath = null
    }

    // Validate target position is within reasonable range
    const currentX = mapCharacter.character.positionX
    const currentY = mapCharacter.character.positionY
    const distance = Math.sqrt(Math.pow(positionX - currentX, 2) + Math.pow(positionY - currentY, 2))

    const path = await this.characterService.calculatePath(mapCharacter.character, positionX, positionY)
    if (!path?.length) {
      this.io.in(mapCharacter.character.map.id).emit(SocketEvent.MAP_CHARACTER_MOVEERROR, 'No valid path found')
      return
    }

    // Start new movement
    mapCharacter.isMoving = true
    mapCharacter.currentPath = path
    await this.moveAlongPath(mapCharacter, path)
  }

  private async moveAlongPath(mapCharacter: MapCharacter, path: Array<{ positionX: number; positionY: number }>): Promise<void> {
    const character = mapCharacter.getCharacter()

    try {
      for (let i = 0; i < path.length - 1; i++) {
        if (!mapCharacter.isMoving || mapCharacter.currentPath !== path) {
          return
        }

        const [start, end] = [path[i], path[i + 1]]

        if (!start || !end) {
          this.logger.error('Invalid path step detected')
          break
        }

        if (i !== 0) {
          await this.characterService.applyMovementDelay()
        }

        // Validate each step
        if (Math.abs(end.positionX - start.positionX) > 1 || Math.abs(end.positionY - start.positionY) > 1) {
          this.logger.error('Invalid path step detected')
          break
        }

        character.setRotation(CharacterService.calculateRotation(start.positionX, start.positionY, end.positionX, end.positionY))

        const mapEventTileRepository = new MapEventTileRepository()
        const mapEventTile = await mapEventTileRepository.getEventTileByMapIdAndPosition(character.getMap().getId(), Math.floor(end.positionX), Math.floor(end.positionY))

        if (mapEventTile?.type === 'BLOCK') break
        if (mapEventTile?.type === 'TELEPORT' && mapEventTile.teleport) {
          await this.handleTeleportMapEventTile(mapEventTile as MapEventTileWithTeleport)
          return
        }

        // Update position first
        character.setPositionX(end.positionX).setPositionY(end.positionY)

        // Then emit with the same properties
        this.io.in(character.map.id).emit(SocketEvent.MAP_CHARACTER_MOVE, {
          characterId: character.id,
          positionX: character.getPositionX(),
          positionY: character.getPositionY(),
          rotation: character.getRotation(),
          isMoving: true
        })

        await this.characterService.applyMovementDelay()
      }
    } finally {
      if (mapCharacter.isMoving && mapCharacter.currentPath === path) {
        this.finalizeMovement(mapCharacter)
      }
    }
  }

  private async handleTeleportMapEventTile(mapEventTile: MapEventTileWithTeleport): Promise<void> {
    if (mapEventTile.getTeleport()) {
      await TeleportService.teleportCharacter(this.socket.characterId, {
        targetMapId: mapEventTile.getTeleport()!.getToMap().getId(),
        targetX: mapEventTile.getTeleport()!.getToPositionX(),
        targetY: mapEventTile.getTeleport()!.getToPositionY(),
        rotation: mapEventTile.getTeleport()!.getToRotation()
      })
    }
  }

  private finalizeMovement(mapCharacter: MapCharacter): void {
    mapCharacter.isMoving = false
    this.io.in(mapCharacter.character.map.id).emit(SocketEvent.MAP_CHARACTER_MOVE, {
      characterId: mapCharacter.character.id,
      positionX: mapCharacter.character.positionX,
      positionY: mapCharacter.character.positionY,
      rotation: mapCharacter.character.rotation,
      isMoving: mapCharacter.isMoving
    })
  }
}