From 01ed1bce291f9019bf22382edb04918d09083260 Mon Sep 17 00:00:00 2001
From: Dennis Postma <dennis@directonline.io>
Date: Wed, 13 Nov 2024 13:25:03 +0100
Subject: [PATCH] #233: Replaced all console logs, thrown errors with logger
 API

---
 .../gameMaster/assetManager/characterType/remove.ts        | 5 +++--
 src/socketEvents/gameMaster/assetManager/object/remove.ts  | 5 +++--
 src/socketEvents/gameMaster/assetManager/sprite/update.ts  | 7 ++++---
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/socketEvents/gameMaster/assetManager/characterType/remove.ts b/src/socketEvents/gameMaster/assetManager/characterType/remove.ts
index 883e577..160b9c3 100644
--- a/src/socketEvents/gameMaster/assetManager/characterType/remove.ts
+++ b/src/socketEvents/gameMaster/assetManager/characterType/remove.ts
@@ -4,6 +4,7 @@ import { TSocket } from '../../../../utilities/types'
 import prisma from '../../../../utilities/prisma'
 import characterRepository from '../../../../repositories/characterRepository'
 import { getPublicPath } from '../../../../utilities/storage'
+import { gameMasterLogger } from '../../../../utilities/logger'
 
 interface IPayload {
   object: string
@@ -41,7 +42,7 @@ export default class ObjectRemoveEvent {
       const finalFilePath = getPublicPath('objects', data.object + '.png')
       fs.unlink(finalFilePath, (err) => {
         if (err) {
-          console.log(err)
+          gameMasterLogger.error(`Error deleting object ${data.object}: ${(err.message)}`)
           callback(false)
           return
         }
@@ -49,7 +50,7 @@ export default class ObjectRemoveEvent {
         callback(true)
       })
     } catch (e) {
-      console.log(e)
+      gameMasterLogger.error(`Error deleting object ${data.object}: ${(e.message)}`)
       callback(false)
     }
   }
diff --git a/src/socketEvents/gameMaster/assetManager/object/remove.ts b/src/socketEvents/gameMaster/assetManager/object/remove.ts
index 883e577..8e9684d 100644
--- a/src/socketEvents/gameMaster/assetManager/object/remove.ts
+++ b/src/socketEvents/gameMaster/assetManager/object/remove.ts
@@ -4,6 +4,7 @@ import { TSocket } from '../../../../utilities/types'
 import prisma from '../../../../utilities/prisma'
 import characterRepository from '../../../../repositories/characterRepository'
 import { getPublicPath } from '../../../../utilities/storage'
+import { gameLogger, gameMasterLogger } from '../../../../utilities/logger'
 
 interface IPayload {
   object: string
@@ -41,7 +42,7 @@ export default class ObjectRemoveEvent {
       const finalFilePath = getPublicPath('objects', data.object + '.png')
       fs.unlink(finalFilePath, (err) => {
         if (err) {
-          console.log(err)
+          gameMasterLogger.error(`Error deleting object ${data.object}: ${(err.message)}`)
           callback(false)
           return
         }
@@ -49,7 +50,7 @@ export default class ObjectRemoveEvent {
         callback(true)
       })
     } catch (e) {
-      console.log(e)
+      gameLogger.error(`Error deleting object ${data.object}: ${(e.message)}`)
       callback(false)
     }
   }
diff --git a/src/socketEvents/gameMaster/assetManager/sprite/update.ts b/src/socketEvents/gameMaster/assetManager/sprite/update.ts
index 3e73acd..a483533 100644
--- a/src/socketEvents/gameMaster/assetManager/sprite/update.ts
+++ b/src/socketEvents/gameMaster/assetManager/sprite/update.ts
@@ -6,6 +6,7 @@ import { writeFile, mkdir } from 'node:fs/promises'
 import sharp from 'sharp'
 import { getPublicPath } from '../../../../utilities/storage'
 import CharacterRepository from '../../../../repositories/characterRepository'
+import { gameMasterLogger } from '../../../../utilities/logger'
 
 type SpriteActionInput = Omit<SpriteAction, 'id' | 'spriteId' | 'frameWidth' | 'frameHeight'> & {
   sprites: string[]
@@ -60,11 +61,11 @@ export default class SpriteUpdateEvent {
       try {
         const parsed = JSON.parse(JSON.stringify(spriteActions)) as SpriteActionInput[]
         if (!Array.isArray(parsed)) {
-          throw new Error('spriteActions is not an array')
+          gameMasterLogger.error('Error parsing spriteActions: spriteActions is not an array')
         }
         return parsed
       } catch (error) {
-        console.error('Error parsing spriteActions:', error)
+        gameMasterLogger.error('Error parsing spriteActions:', error)
         throw error
       }
     }
@@ -75,7 +76,7 @@ export default class SpriteUpdateEvent {
           const { action, sprites } = spriteAction
 
           if (!Array.isArray(sprites) || sprites.length === 0) {
-            throw new Error(`Invalid sprites array for action: ${action}`)
+            gameMasterLogger.error(`Invalid sprites array for action: ${action}`)
           }
 
           const buffersWithDimensions = await Promise.all(