From 1b87f1dd914f47ff2d37f5a70fd113a9222429a3 Mon Sep 17 00:00:00 2001
From: Dennis Postma <dennis@directonline.io>
Date: Wed, 25 Dec 2024 17:28:35 +0100
Subject: [PATCH] Minor repo improvement

---
 src/services/worldService.ts                           |  6 +-----
 .../gameMaster/assetManager/characterType/delete.ts    | 10 +++++-----
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/services/worldService.ts b/src/services/worldService.ts
index 958583a..4d45e59 100644
--- a/src/services/worldService.ts
+++ b/src/services/worldService.ts
@@ -8,8 +8,6 @@ class WorldService {
       let world = await WorldRepository.getFirst()
       if (!world) {
         world = new World()
-
-        await world.save()
       }
 
       world.date = worldData.date || new Date()
@@ -27,9 +25,7 @@ class WorldService {
         world.fogDensity = worldData.fogDensity
       }
 
-      console.log(world.date)
-
-      await world.update()
+      await world.save()
 
       return true
     } catch (error: any) {
diff --git a/src/socketEvents/gameMaster/assetManager/characterType/delete.ts b/src/socketEvents/gameMaster/assetManager/characterType/delete.ts
index edafb69..4916832 100644
--- a/src/socketEvents/gameMaster/assetManager/characterType/delete.ts
+++ b/src/socketEvents/gameMaster/assetManager/characterType/delete.ts
@@ -1,8 +1,8 @@
 import { Server } from 'socket.io'
 import { TSocket } from '#application/types'
-import prisma from '#application/prisma'
-import characterRepository from '#repositories/characterRepository'
 import { gameMasterLogger } from '#application/logger'
+import characterRepository from '#repositories/characterRepository'
+import CharacterTypeRepository from '#repositories/characterTypeRepository'
 
 interface IPayload {
   id: number
@@ -27,10 +27,10 @@ export default class CharacterTypeDeleteEvent {
     }
 
     try {
-      await prisma.characterType.delete({
-        where: { id: data.id }
-      })
+      const characterType = await CharacterTypeRepository.getById(data.id)
+      if (!characterType) return callback(false)
 
+      await characterType.delete()
       callback(true)
     } catch (error) {
       gameMasterLogger.error(`Error deleting character type ${data.id}: ${error instanceof Error ? error.message : String(error)}`)