Better var. naming

This commit is contained in:
2025-01-09 15:58:16 +01:00
parent 849ef07297
commit 458293a5fc
5 changed files with 106 additions and 145 deletions

View File

@ -38,7 +38,7 @@ export default class CharacterMove extends BaseEvent {
await this.moveAlongPath(mapCharacter, path)
}
private async moveAlongPath(mapCharacter: MapCharacter, path: Array<{ x: number; y: number }>): Promise<void> {
private async moveAlongPath(mapCharacter: MapCharacter, path: Array<{ positionX: number; positionY: number }>): Promise<void> {
const character = mapCharacter.getCharacter()
for (let i = 0; i < path.length - 1; i++) {
@ -47,7 +47,7 @@ export default class CharacterMove extends BaseEvent {
}
const [start, end] = [path[i], path[i + 1]]
character.setRotation(CharacterService.calculateRotation(start.x, start.y, end.x, end.y))
character.setRotation(CharacterService.calculateRotation(start.positionX, start.positionY, end.positionX, end.positionY))
const mapEventTileRepository = new MapEventTileRepository()
const mapEventTile = await mapEventTileRepository.getEventTileByMapIdAndPosition(character.getMap().getId(), Math.floor(end.x), Math.floor(end.y))
@ -59,7 +59,7 @@ export default class CharacterMove extends BaseEvent {
}
// Update position first
character.setPositionX(end.x).setPositionY(end.y)
character.setPositionX(end.positionX).setPositionY(end.positionY)
// Then emit with the same properties
this.io.in(character.map.id).emit('map:character:move', {