From 6ee8bb8334908d730a4296ab37af18acaa759c50 Mon Sep 17 00:00:00 2001
From: Dennis Postma <dennis@directonline.io>
Date: Sun, 17 Nov 2024 18:00:58 +0100
Subject: [PATCH] Minor improvements for char. type management

---
 .../assetManager/characterType/delete.ts      | 22 +++++--------------
 .../gameMaster/assetManager/sprite/delete.ts  |  4 ++--
 2 files changed, 7 insertions(+), 19 deletions(-)

diff --git a/src/socketEvents/gameMaster/assetManager/characterType/delete.ts b/src/socketEvents/gameMaster/assetManager/characterType/delete.ts
index 46b043b..17567d2 100644
--- a/src/socketEvents/gameMaster/assetManager/characterType/delete.ts
+++ b/src/socketEvents/gameMaster/assetManager/characterType/delete.ts
@@ -7,7 +7,7 @@ import { getPublicPath } from '../../../../utilities/storage'
 import { gameMasterLogger } from '../../../../utilities/logger'
 
 interface IPayload {
-  object: string
+  id: number
 }
 
 export default class CharacterTypeDeleteEvent {
@@ -29,25 +29,13 @@ export default class CharacterTypeDeleteEvent {
     }
 
     try {
-      await prisma.object.delete({
-        where: {
-          id: data.object
-        }
+      await prisma.characterType.delete({
+        where: { id: data.id }
       })
 
-      // remove the tile from the disk
-      const finalFilePath = getPublicPath('objects', data.object + '.png')
-      fs.unlink(finalFilePath, (err) => {
-        if (err) {
-          gameMasterLogger.error(`Error deleting object ${data.object}: ${err.message}`)
-          callback(false)
-          return
-        }
-
-        callback(true)
-      })
+      callback(true)
     } catch (error) {
-      gameMasterLogger.error(`Error deleting object ${data.object}: ${error instanceof Error ? error.message : String(error)}`)
+      gameMasterLogger.error(`Error deleting character type ${data.id}: ${error instanceof Error ? error.message : String(error)}`)
       callback(false)
     }
   }
diff --git a/src/socketEvents/gameMaster/assetManager/sprite/delete.ts b/src/socketEvents/gameMaster/assetManager/sprite/delete.ts
index 9bfc747..21c645f 100644
--- a/src/socketEvents/gameMaster/assetManager/sprite/delete.ts
+++ b/src/socketEvents/gameMaster/assetManager/sprite/delete.ts
@@ -21,10 +21,10 @@ export default class GMSpriteDeleteEvent {
   }
 
   public listen(): void {
-    this.socket.on('gm:sprite:delete', this.handleSpriteDelete.bind(this))
+    this.socket.on('gm:sprite:delete', this.handleEvent.bind(this))
   }
 
-  private async handleSpriteDelete(data: Payload, callback: (response: boolean) => void): Promise<void> {
+  private async handleEvent(data: Payload, callback: (response: boolean) => void): Promise<void> {
     const character = await CharacterRepository.getById(this.socket.characterId!)
     if (character?.role !== 'gm') {
       return callback(false)