Converted socketEvents to new format

Still need to rework 'any' type Promises

src/socketEvents/character/connect.ts

@@ -7,18 +7,27 @@ type SocketResponseT = {
   character_id: number
 }
 
-export default function (io: Server, socket: TSocket) {
-  socket.on('character:connect', async (data: SocketResponseT) => {
+export default class CharacterConnectEvent {
+  constructor(
+    private readonly io: Server,
+    private readonly socket: TSocket
+  ) {}
+
+  public listen(): void {
+    this.socket.on('character:connect', this.handleCharacterConnect.bind(this))
+  }
+
+  private async handleCharacterConnect(data: SocketResponseT): Promise<void> {
     console.log('character:connect requested', data)
     try {
-      const character = await CharacterRepository.getByUserAndId(socket?.user?.id as number, data.character_id)
+      const character = await CharacterRepository.getByUserAndId(this.socket?.user?.id as number, data.character_id)
       if (!character) return
-      socket.characterId = character.id
+      this.socket.characterId = character.id
 
       CharacterManager.initCharacter(character as ExtendedCharacter)
-      socket.emit('character:connect', character)
+      this.socket.emit('character:connect', character)
     } catch (error: any) {
       console.log('character:connect error', error)
     }
-  })
-}
+  }
+}

src/socketEvents/character/create.ts

@@ -6,26 +6,35 @@ import { ZCharacterCreate } from '../../utilities/zodTypes'
 import prisma from '../../utilities/prisma'
 import { gameLogger } from '../../utilities/logger'
 
-export default function (io: Server, socket: TSocket) {
-  socket.on('character:create', async (data: any) => {
+export default class CharacterCreateEvent {
+  constructor(
+    private readonly io: Server,
+    private readonly socket: TSocket
+  ) {}
+
+  public listen(): void {
+    this.socket.on('character:create', this.handleCharacterCreate.bind(this))
+  }
+
+  private async handleCharacterCreate(data: any): Promise<any> {
     console.log('character:create requested', data)
     // zod validate
     try {
       data = ZCharacterCreate.parse(data)
 
-      const user_id = socket.user?.id as number
+      const user_id = this.socket.user?.id as number
 
       // Check if character name already exists
       const characterExists = await CharacterRepository.getByName(data.name)
 
       if (characterExists) {
-        return socket.emit('notification', { message: 'Character name already exists' })
+        return this.socket.emit('notification', { message: 'Character name already exists' })
       }
 
       let characters: Character[] = (await CharacterRepository.getByUserId(user_id)) as Character[]
 
       if (characters.length >= 4) {
-        return socket.emit('notification', { message: 'You can only have 4 characters' })
+        return this.socket.emit('notification', { message: 'You can only have 4 characters' })
       }
 
       const character: Character = await prisma.character.create({
@@ -38,14 +47,14 @@ export default function (io: Server, socket: TSocket) {
 
       characters = [...characters, character]
 
-      socket.emit('character:create:success')
-      socket.emit('character:list', characters)
+      this.socket.emit('character:create:success')
+      this.socket.emit('character:list', characters)
 
       gameLogger.info('character:create success')
     } catch (error: any) {
       console.log(error)
       gameLogger.error(`character:create error: ${error.message}`)
-      return socket.emit('notification', { message: 'Could not create character. Please try again (later).' })
+      return this.socket.emit('notification', { message: 'Could not create character. Please try again (later).' })
     }
-  })
-}
+  }
+}

src/socketEvents/character/delete.ts

@@ -12,19 +12,28 @@ type TypeResponse = {
   characters: Character[]
 }
 
-export default function (io: Server, socket: TSocket) {
-  socket.on('character:delete', async (data: TypePayload, callback: (response: TypeResponse) => void) => {
+export default class CharacterDeleteEvent {
+  constructor(
+    private readonly io: Server,
+    private readonly socket: TSocket
+  ) {}
+
+  public listen(): void {
+    this.socket.on('character:delete', this.handleCharacterDelete.bind(this))
+  }
+
+  private async handleCharacterDelete(data: TypePayload, callback: (response: TypeResponse) => void): Promise<any> {
     // zod validate
     try {
-      await CharacterRepository.deleteByUserIdAndId(socket.user?.id as number, data.character_id as number)
+      await CharacterRepository.deleteByUserIdAndId(this.socket.user?.id as number, data.character_id as number)
 
-      const user_id = socket.user?.id as number
+      const user_id = this.socket.user?.id as number
       const characters: Character[] = (await CharacterRepository.getByUserId(user_id)) as Character[]
 
-      socket.emit('character:list', characters)
+      this.socket.emit('character:list', characters)
     } catch (error: any) {
       console.log(error)
-      return socket.emit('notification', { message: 'Character delete failed. Please try again.' })
+      return this.socket.emit('notification', { message: 'Character delete failed. Please try again.' })
     }
-  })
-}
+  }
+}

src/socketEvents/character/list.ts

@@ -3,15 +3,24 @@ import { TSocket } from '../../utilities/types'
 import { Character } from '@prisma/client'
 import CharacterRepository from '../../repositories/characterRepository'
 
-export default function CharacterList(io: Server, socket: TSocket) {
-  socket.on('character:list', async (data: any) => {
+export default class CharacterListEvent {
+  constructor(
+    private readonly io: Server,
+    private readonly socket: TSocket
+  ) {}
+
+  public listen(): void {
+    this.socket.on('character:list', this.handleCharacterList.bind(this))
+  }
+
+  private async handleCharacterList(data: any): Promise<void> {
     try {
       console.log('character:list requested')
-      const user_id = socket.user?.id as number
+      const user_id = this.socket.user?.id as number
       const characters: Character[] = (await CharacterRepository.getByUserId(user_id)) as Character[]
-      socket.emit('character:list', characters)
+      this.socket.emit('character:list', characters)
     } catch (error: any) {
       console.log('character:list error', error)
     }
-  })
-}
+  }
+}