Converted socketEvents to new format

Still need to rework 'any' type Promises

src/socketEvents/gameMaster/assetManager/object/list.ts

@@ -7,14 +7,18 @@ import characterRepository from '../../../../repositories/characterRepository'
 
 interface IPayload {}
 
-/**
- * Handle game master list object event
- * @param socket
- * @param io
- */
-export default function (io: Server, socket: TSocket) {
-  socket.on('gm:object:list', async (data: any, callback: (response: Object[]) => void) => {
-    const character = await characterRepository.getById(socket.characterId as number)
+export default class ObjectListEvent {
+  constructor(
+    private readonly io: Server,
+    private readonly socket: TSocket
+  ) {}
+
+  public listen(): void {
+    this.socket.on('gm:object:list', this.handleObjectList.bind(this))
+  }
+
+  private async handleObjectList(data: IPayload, callback: (response: Object[]) => void): Promise<void> {
+    const character = await characterRepository.getById(this.socket.characterId as number)
     if (!character) return callback([])
 
     if (character.role !== 'gm') {
@@ -24,5 +28,5 @@ export default function (io: Server, socket: TSocket) {
     // get all objects
     const objects = await ObjectRepository.getAll()
     callback(objects)
-  })
-}
+  }
+}

src/socketEvents/gameMaster/assetManager/object/remove.ts

@@ -10,14 +10,18 @@ interface IPayload {
   object: string
 }
 
-/**
- * Handle game master remove object event
- * @param socket
- * @param io
- */
-export default function (io: Server, socket: TSocket) {
-  socket.on('gm:object:remove', async (data: IPayload, callback: (response: boolean) => void) => {
-    const character = await characterRepository.getById(socket.characterId as number)
+export default class ObjectRemoveEvent {
+  constructor(
+    private readonly io: Server,
+    private readonly socket: TSocket
+  ) {}
+
+  public listen(): void {
+    this.socket.on('gm:object:remove', this.handleObjectRemove.bind(this))
+  }
+
+  private async handleObjectRemove(data: IPayload, callback: (response: boolean) => void): Promise<void> {
+    const character = await characterRepository.getById(this.socket.characterId as number)
     if (!character) return callback(false)
 
     if (character.role !== 'gm') {
@@ -49,5 +53,5 @@ export default function (io: Server, socket: TSocket) {
       console.log(e)
       callback(false)
     }
-  })
-}
+  }
+}

src/socketEvents/gameMaster/assetManager/object/update.ts

@@ -16,14 +16,18 @@ type Payload = {
   frameHeight: number
 }
 
-/**
- * Handle game master object update event
- * @param socket
- * @param io
- */
-export default function (io: Server, socket: TSocket) {
-  socket.on('gm:object:update', async (data: Payload, callback: (success: boolean) => void) => {
-    const character = await characterRepository.getById(socket.characterId as number)
+export default class ObjectUpdateEvent {
+  constructor(
+    private readonly io: Server,
+    private readonly socket: TSocket
+  ) {}
+
+  public listen(): void {
+    this.socket.on('gm:object:update', this.handleObjectUpdate.bind(this))
+  }
+
+  private async handleObjectUpdate(data: Payload, callback: (success: boolean) => void): Promise<void> {
+    const character = await characterRepository.getById(this.socket.characterId as number)
     if (!character) return callback(false)
 
     if (character.role !== 'gm') {
@@ -51,5 +55,5 @@ export default function (io: Server, socket: TSocket) {
       console.error(error)
       callback(false)
     }
-  })
-}
+  }
+}