noxious/server
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

#233: Replaced all console logs, thrown errors with logger API

Browse Source
This commit is contained in:
Dennis Postma 2024-11-13 13:25:03 +01:00
parent d4e0cbe398
commit 01ed1bce29
3 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/socketEvents/gameMaster/assetManager/characterType/remove.ts
View File

@ -4,6 +4,7 @@ import { TSocket } from '../../../../utilities/types'
import prisma from '../../../../utilities/prisma' import prisma from '../../../../utilities/prisma'
import characterRepository from '../../../../repositories/characterRepository' import characterRepository from '../../../../repositories/characterRepository'
import { getPublicPath } from '../../../../utilities/storage' import { getPublicPath } from '../../../../utilities/storage'
import { gameMasterLogger } from '../../../../utilities/logger'
interface IPayload { interface IPayload {
object: string object: string
@ -41,7 +42,7 @@ export default class ObjectRemoveEvent {
const finalFilePath = getPublicPath('objects', data.object + '.png') const finalFilePath = getPublicPath('objects', data.object + '.png')
fs.unlink(finalFilePath, (err) => { fs.unlink(finalFilePath, (err) => {
if (err) { if (err) {
console.log(err) gameMasterLogger.error(`Error deleting object ${data.object}: ${(err.message)}`)
callback(false) callback(false)
return return
} }
@ -49,7 +50,7 @@ export default class ObjectRemoveEvent {
callback(true) callback(true)
}) })
} catch (e) { } catch (e) {
console.log(e) gameMasterLogger.error(`Error deleting object ${data.object}: ${(e.message)}`)
callback(false) callback(false)
} }
} }

5
src/socketEvents/gameMaster/assetManager/object/remove.ts
View File

@ -4,6 +4,7 @@ import { TSocket } from '../../../../utilities/types'
import prisma from '../../../../utilities/prisma' import prisma from '../../../../utilities/prisma'
import characterRepository from '../../../../repositories/characterRepository' import characterRepository from '../../../../repositories/characterRepository'
import { getPublicPath } from '../../../../utilities/storage' import { getPublicPath } from '../../../../utilities/storage'
import { gameLogger, gameMasterLogger } from '../../../../utilities/logger'
interface IPayload { interface IPayload {
object: string object: string
@ -41,7 +42,7 @@ export default class ObjectRemoveEvent {
const finalFilePath = getPublicPath('objects', data.object + '.png') const finalFilePath = getPublicPath('objects', data.object + '.png')
fs.unlink(finalFilePath, (err) => { fs.unlink(finalFilePath, (err) => {
if (err) { if (err) {
console.log(err) gameMasterLogger.error(`Error deleting object ${data.object}: ${(err.message)}`)
callback(false) callback(false)
return return
} }
@ -49,7 +50,7 @@ export default class ObjectRemoveEvent {
callback(true) callback(true)
}) })
} catch (e) { } catch (e) {
console.log(e) gameLogger.error(`Error deleting object ${data.object}: ${(e.message)}`)
callback(false) callback(false)
} }
} }

7
src/socketEvents/gameMaster/assetManager/sprite/update.ts
View File

@ -6,6 +6,7 @@ import { writeFile, mkdir } from 'node:fs/promises'
import sharp from 'sharp' import sharp from 'sharp'
import { getPublicPath } from '../../../../utilities/storage' import { getPublicPath } from '../../../../utilities/storage'
import CharacterRepository from '../../../../repositories/characterRepository' import CharacterRepository from '../../../../repositories/characterRepository'
import { gameMasterLogger } from '../../../../utilities/logger'
type SpriteActionInput = Omit<SpriteAction, 'id' | 'spriteId' | 'frameWidth' | 'frameHeight'> & { type SpriteActionInput = Omit<SpriteAction, 'id' | 'spriteId' | 'frameWidth' | 'frameHeight'> & {
sprites: string[] sprites: string[]
@ -60,11 +61,11 @@ export default class SpriteUpdateEvent {
try { try {
const parsed = JSON.parse(JSON.stringify(spriteActions)) as SpriteActionInput[] const parsed = JSON.parse(JSON.stringify(spriteActions)) as SpriteActionInput[]
if (!Array.isArray(parsed)) { if (!Array.isArray(parsed)) {
throw new Error('spriteActions is not an array') gameMasterLogger.error('Error parsing spriteActions: spriteActions is not an array')
} }
return parsed return parsed
} catch (error) { } catch (error) {
console.error('Error parsing spriteActions:', error) gameMasterLogger.error('Error parsing spriteActions:', error)
throw error throw error
} }
} }
@ -75,7 +76,7 @@ export default class SpriteUpdateEvent {
const { action, sprites } = spriteAction const { action, sprites } = spriteAction
if (!Array.isArray(sprites) || sprites.length === 0) { if (!Array.isArray(sprites) || sprites.length === 0) {
throw new Error(`Invalid sprites array for action: ${action}`) gameMasterLogger.error(`Invalid sprites array for action: ${action}`)
} }
const buffersWithDimensions = await Promise.all( const buffersWithDimensions = await Promise.all(